Make sure the default user agent is ASCII. #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RecordedRequest request = server.takeRequest(); | ||
| assertEquals("a?b?c?d?e", request.getHeader("User-Agent")); | ||
| } | ||
|
|
||
| @Test public void userAgentDefaultsToJavaVersion() throws Exception { |
There was a problem hiding this comment.
nit: test name is wrong
swankjesse
force-pushed
the
jwilson_0803_default_user_agent
branch
from
06dbedc
to
39c27ef
Compare
|
LGTM |
|
Needs a rebase. |
swankjesse
force-pushed
the
jwilson_0803_default_user_agent
branch
from
39c27ef
to
0e7524d
Compare
swankjesse
added a commit
that referenced
this pull request
Aug 3, 2015
Make sure the default user agent is ASCII.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #891