Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure discarded HTTP/2 data frames free flow-control space. #4033

Merged
merged 1 commit into from
May 30, 2018
Merged

Ensure discarded HTTP/2 data frames free flow-control space. #4033

merged 1 commit into from
May 30, 2018

Conversation

dave-r12
Copy link
Collaborator

yschimke
yschimke approved these changes May 29, 2018
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes logical sense to me. And seems to match previous assumption about when things affect flow control.

swankjesse
swankjesse approved these changes May 30, 2018
View reviewed changes
Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic.

okhttp-tests/src/test/java/okhttp3/internal/http2/Http2ConnectionTest.java
InFrame frame3 = peer.takeFrame();
assertEquals(Http2.TYPE_RST_STREAM, frame3.type);

assertEquals(2048, connection.unacknowledgedBytesRead);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test

@swankjesse swankjesse merged commit f9cef65 into master May 30, 2018
swankjesse pushed a commit that referenced this pull request May 30, 2018
@dave-r12 @squarejesse
Ensure discarded HTTP/2 data frames free flow-control space. (#4033)
fb83491 
#3915
swankjesse pushed a commit that referenced this pull request May 30, 2018
@squarejesse
Merge branch 'based2-patch-1'
a64ee6a 
* based2-patch-1:
  Ensure discarded HTTP/2 data frames free flow-control space. (#4033)
  Use header delay instead of body delay before status line (#4011)
  update maven plugins and apache.httpcomponents/httpclient to 4.2.6
swankjesse pushed a commit that referenced this pull request May 30, 2018
@squarejesse
Merge branch 'based2-patch-1'
6d1d273 
* based2-patch-1:
  Ensure discarded HTTP/2 data frames free flow-control space. (#4033)
  Use header delay instead of body delay before status line (#4011)
  update maven plugins and apache.httpcomponents/httpclient to 4.2.6
swankjesse pushed a commit that referenced this pull request May 30, 2018
@squarejesse
Merge branch 'based2-patch-1'
e719655 
* based2-patch-1:
  Ensure discarded HTTP/2 data frames free flow-control space. (#4033)
  Use header delay instead of body delay before status line (#4011)
  update maven plugins and apache.httpcomponents/httpclient to 4.2.6
@JakeWharton JakeWharton deleted the http2-discarded-data-frames branch June 12, 2018 20:54
@jkozlowski jkozlowski mentioned this pull request Aug 30, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse swankjesse approved these changes

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dave-r12 @swankjesse @yschimke