Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use Android 10 API for session tickets #5525

Closed
wants to merge 1 commit into from

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Oct 2, 2019

No description provided.

@yschimke yschimke changed the title Use Android 10 API for session tickets [WIP] Use Android 10 API for session tickets Oct 2, 2019
@yschimke
Copy link
Collaborator Author

yschimke commented Oct 2, 2019

Android tests running OK

10:43:12 V/InstrumentationResultParser: Time: 5.479
10:43:12 V/InstrumentationResultParser:
10:43:12 V/InstrumentationResultParser: OK (12 tests)
10:43:12 V/InstrumentationResultParser:
10:43:12 V/InstrumentationResultParser:
10:43:12 V/InstrumentationResultParser: INSTRUMENTATION_CODE: -1
10:43:12 V/InstrumentationResultParser:
10:43:12 I/XmlResultReporter: XML test result file generated at /Users/yuri/workspace/okhttp/android-test/build/outputs/androidTest-results/connected/TEST-2.7_QVGA_API_29(AVD) - 10-android-test-.xml. Total tests 13, passed 11, assumption_failure 1, ignored 1,
10:43:12 V/ddms: execute 'am instrument -w -r   -e notClass org.conscrypt.KitKatPlatformOpenSSLSocketImplAdapter okhttp.android.test.test/android.support.test.runner.AndroidJUnitRunner' on 'emulator-5554' : EOF hit. Read: -1
10:43:12 V/ddms: execute: returning
10:43:12 V/ddms: execute: running pm uninstall okhttp.android.test.test
10:43:12 V/ddms: execute 'pm uninstall okhttp.android.test.test' on 'emulator-5554' : EOF hit. Read: -1
10:43:12 V/ddms: execute: returning

> Task :android-test:connectedAndroidTest
> Task :android-test:connectedCheck

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 1m 36s

@yschimke
Copy link
Collaborator Author

yschimke commented Oct 2, 2019

Yuck

$ ./gradlew :okhttp:animalsnifferMain --stacktrace
...
Caused by: java.io.IOException:  failed to process jar /Users/yuri/.gradle/caches/modules-2/files-2.1/org.robolectric/android-all/Q-robolectric-5415296/675f28b006b4836563afee8d2f8468fece4d5bd7/android-all-Q-robolectric-5415296.jar : Bad class file /Users/yuri/.gradle/caches/modules-2/files-2.1/org.robolectric/android-all/Q-robolectric-5415296/675f28b006b4836563afee8d2f8468fece4d5bd7/android-all-Q-robolectric-5415296.jar:libcore/io/Os.class
	at org.codehaus.mojo.animal_sniffer.ClassFileVisitor.processJarFile(ClassFileVisitor.java:185)
	at org.codehaus.mojo.animal_sniffer.ClassFileVisitor.process(ClassFileVisitor.java:120)
	at org.codehaus.mojo.animal_sniffer.ant.CheckSignatureTask.apply(CheckSignatureTask.java:272)
	at org.codehaus.mojo.animal_sniffer.ant.CheckSignatureTask.buildPackageList(CheckSignatureTask.java:246)
	at org.codehaus.mojo.animal_sniffer.ant.CheckSignatureTask.execute(CheckSignatureTask.java:166)
	... 119 more
Caused by: java.io.IOException: Bad class file /Users/yuri/.gradle/caches/modules-2/files-2.1/org.robolectric/android-all/Q-robolectric-5415296/675f28b006b4836563afee8d2f8468fece4d5bd7/android-all-Q-robolectric-5415296.jar:libcore/io/Os.class
	at org.codehaus.mojo.animal_sniffer.ClassListBuilder.process(ClassListBuilder.java:91)
	at org.codehaus.mojo.animal_sniffer.ClassFileVisitor.processJarFile(ClassFileVisitor.java:175)
	... 123 more
Caused by: java.lang.IllegalArgumentException
	at org.codehaus.mojo.animal_sniffer.asm.shaded.ClassReader.<init>(Unknown Source)
	at org.codehaus.mojo.animal_sniffer.asm.shaded.ClassReader.<init>(Unknown Source)
	at org.codehaus.mojo.animal_sniffer.asm.shaded.ClassReader.<init>(Unknown Source)
	at org.codehaus.mojo.animal_sniffer.ClassListBuilder.process(ClassListBuilder.java:69)
	... 124 more

@yschimke
Copy link
Collaborator Author

yschimke commented Oct 2, 2019

Raised mojohaus/animal-sniffer#70

@yschimke
Copy link
Collaborator Author

yschimke commented Oct 4, 2019

Closing until resolved upstream. We can live with deprecated API for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant