Add a proper Kotlin constructor for Request #7208
Conversation
This turns out to be very useful throughout our test suite.
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.junit.jupiter.api.Assertions.fail; | ||
|
|
||
| public final class RequestTest { |
There was a problem hiding this comment.
Converted to Kotlin.
| } | ||
| } | ||
|
|
||
| @Test public void headerForbidsNullArguments() { |
There was a problem hiding this comment.
This particular test dropped.
| import org.assertj.core.api.Assertions.fail | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| class RequestTest { |
There was a problem hiding this comment.
Converted from Java. The first 4 tests are new.
|
okhttp-android/src/androidTest/kotlin/okhttp3/android/AndroidAsyncDnsTest.kt
Show resolved
Hide resolved
| constructor( | ||
| url: HttpUrl, | ||
| headers: Headers = Headers.headersOf(), | ||
| method: String = "\u0000", // Sentinel value chooses based on what the body is. |
There was a problem hiding this comment.
Cute, was a bit against it at first, but it hits the sweet spot for usage.
There was a problem hiding this comment.
It also removes the comment I came here to make, that HttpMethods should be public API, since you need to pass in here. But not an issue since this can be left out mostly.
There was a problem hiding this comment.
I considered null as the sentinel, but that lets users pass null which I don’t like.
I considered making the when expression the default value, but that puts the parameters in a surprising order.
This is ugly, but users shouldn’t see it.
There was a problem hiding this comment.
2028: IETF formalises the \u0000 Verb based on widespread popularity of the just do what you need to semantics...
There was a problem hiding this comment.
Ooooh think of the poor C programmers, strlen on this guy isn't fun.
|
This turns out to be very useful throughout our test suite.