Allow nullable executorService parameter in Dispatcher class constructor #8401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Nullable ExecutorService Parameter in Dispatcher Constructor to maintain backwards compatibility with OkHttp3 3.x migration to 4.x and beyond
linleo345
changed the title
|
Can I get a re-run of the failed check? Looks like it failed |
|
That's ok. Noted. |
swankjesse
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow nullable executorService parameter in Dispatcher.kt constructor to maintain backwards compatibility with OkHttp 3.x migration to 4.x and beyond.
For some more context:
In my internal company's library, there were some code snippets using OkHttp 3.x that passed null into the Dispatcher constructor for the
executorServiceparameter. This worked with the Java implementation of OkHttp library, but with the migration to Kotlin in 4.x and theexecutorServiceparameter not being nullable in Dispatcher constructor, this caused some projects to fail after upgrading from OkHttp 3.x to 4.x