JS IR compiler support #910
Labels
Comments
|
Thanks! Feel free to fire over a PR when upstream is fixed as well! |
This was referenced Mar 23, 2021
|
@JakeWharton Is it acceptable to workaround the issue by dropping default arguments? e.g. - fun lastIndexOf(other: ByteString, fromIndex: Int = size): Int
+ fun lastIndexOf(other: ByteString, fromIndex: Int): Int
+ fun lastIndexOf(other: ByteString): IntNot sure whether this has an ABI impact on JVM though. |
|
@andersio that is not a binary-compatible change. |
swankjesse
pushed a commit
that referenced
this issue
May 22, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. It also works around a bug in IR where Long.toString() returns the wrong value. Closes: #910
swankjesse
pushed a commit
that referenced
this issue
May 22, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
pushed a commit
that referenced
this issue
May 22, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
pushed a commit
that referenced
this issue
May 23, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
pushed a commit
that referenced
this issue
May 23, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
pushed a commit
that referenced
this issue
May 23, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
pushed a commit
that referenced
this issue
May 24, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
pushed a commit
that referenced
this issue
May 25, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
added a commit
that referenced
this issue
May 25, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
pushed a commit
that referenced
this issue
May 25, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
pushed a commit
that referenced
this issue
May 25, 2021
This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910
swankjesse
added a commit
that referenced
this issue
May 26, 2021
* Support Kotlin/JS IR and Legacy JS This introduces a very ugly workaround to a limitation in the IR compiler where default parameter values cannot be functions on the invoked object. https://youtrack.jetbrains.com/issue/KT-45542 It also works around a bug in IR where Long.toString() returns the wrong value. https://youtrack.jetbrains.com/issue/KT-39891 Closes: #910 * Get FileHandle working on NodeJS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While JS IR backend is still in alpha, IR compiler support is valuable to prototype and test TypeScript integration. So it would be great if okio can enable
kotlin.js.compiler=bothat some point.Having said that, when I try to convert square/okio 3.0.0-alpha1 to work with the JS IR compiler, I stumbled upon a compiler bug & filed it as KT-45542. It is reproducible on both Kotlin 1.4.31 and 1.5.0-M1. Since square/okio uses default parameter values in its expect classes quite a lot, guess we will all have to wait then.
The text was updated successfully, but these errors were encountered: