This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Ignore ineligible nodes during in rolling updates #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because rolling updates and node transfers can no longer occur at the same time, marking a node as ineligible during a rolling update can cause a "deadlock" where the roll cannot move forward because an ineligible does not count as healthy.
spenceral
force-pushed
the
roll-ignore-ineligible
branch
from
eb619de
to
ac9ab99
Compare
esuen
approved these changes
Jul 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because rolling updates and node transfers can no longer occur at the
same time, marking a node as ineligible during a rolling update can
cause a "deadlock" where the roll cannot move forward because an
ineligible does not count as healthy.