This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Discard STDOUT and STDERR in p2-logbridge #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenceral
force-pushed
the
logbridge-devnull
branch
from
f455b91
to
c875fe5
Compare
eam
reviewed
Sep 25, 2018
bin/p2-log-bridge/main.go
Outdated
| @@ -27,6 +27,11 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| if err := discardSTDOUTAndSTDERR(); err != nil { | |||
| logging.DefaultLogger.WithError(err).Error("fatal error discarding STDOUT and STDIN") | |||
Environments that use systemd-journald may be affected by a bug in which logbridge write()s will fail with EPIPE if systemd-journald restarts. To avoid this, we can update the STDOUT and STDERR file descriptors to point at /dev/null.
esuen
approved these changes
Sep 25, 2018
eam
approved these changes
Sep 25, 2018
spenceral
force-pushed
the
logbridge-devnull
branch
from
c875fe5
to
4e7edd4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environments that use systemd-journald may be affected by a bug in which
logbridge write()s will fail with EPIPE if systemd-journald restarts. To
avoid this, we can update the STDOUT and STDERR file descriptors to
point at /dev/null.
Context