This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
move preparer hook installation and create preparer init hook type #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* square/master: add feature to mark platform hooks as requred in preparer config Modified test for err == nil when reading invalid bool Adding readbool method to config grpc scheduler: add configurable request timeout
esuen
force-pushed
the
suen.reorder-p2-preparer-hooks-installation
branch
from
64fa057
to
1a1eeda
Compare
…t to within preparer init. Create new hook type PreparerInit to be ran after hooks are installed in preparer initialization. Properly error in ExitUnlessEvent if unrecognized hook type is passed.
esuen
force-pushed
the
suen.reorder-p2-preparer-hooks-installation
branch
from
d6e586e
to
6dc5de5
Compare
derektamsen
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move when hooks are installed for p2-preparer from after preparer init to within preparer init
create new hook type PreparerInit to be ran after hooks are installed in preparer initialization