-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Label from the framework #19
Comments
Please! Found this library looking for this functionality specifically. Cheers 😄 |
@edwellbrook Glad to hear you're finding it useful! Was there specific functionality in Thanks! |
Honestly mostly interested in Thank you! |
ParalayoutStudio, the old sample code for experimenting with Paralayout, was primarily focused on functionality around Label, which is being removed from the framework (square#19). The project was also outdated (lacked support for iPhone X even) and was not set up with a dependency manager, which made adding snapshot tests difficult. This replaces ParalayoutStudio with a new demo app that uses CocoaPods for dependency management (which inherently tests our CocoaPods integration) and includes a test suite set up to run snapshot tests. My plan is to use this demo app both as a way to show how Paralayout can be used and as a form of integration tests. It currently only has the skeleton for this new design, but it should be easy to add new sample screens. I've added a basic snapshot test for view spreading to kick off building out the snapshot test suite.
ParalayoutStudio, the old sample code for experimenting with Paralayout, was primarily focused on functionality around Label, which is being removed from the framework (square#19). The project was also outdated (lacked support for iPhone X even) and was not set up with a dependency manager, which made adding snapshot tests difficult. This replaces ParalayoutStudio with a new demo app that uses CocoaPods for dependency management (which inherently tests our CocoaPods integration) and includes a test suite set up to run snapshot tests. My plan is to use this demo app both as a way to show how Paralayout can be used and as a form of integration tests. It currently only has the skeleton for this new design, but it should be easy to add new sample screens. I've added a basic snapshot test for view spreading to kick off building out the snapshot test suite.
ParalayoutStudio, the old sample code for experimenting with Paralayout, was primarily focused on functionality around Label, which is being removed from the framework (square#19). The project was also outdated (lacked support for iPhone X even) and was not set up with a dependency manager, which made adding snapshot tests difficult. This replaces ParalayoutStudio with a new demo app that uses CocoaPods for dependency management (which inherently tests our CocoaPods integration) and includes a test suite set up to run snapshot tests. My plan is to use this demo app both as a way to show how Paralayout can be used and as a form of integration tests. It currently only has the skeleton for this new design, but it should be easy to add new sample screens. I've added a basic snapshot test for view spreading to kick off building out the snapshot test suite.
ParalayoutStudio, the old sample code for experimenting with Paralayout, was primarily focused on functionality around Label, which is being removed from the framework (square#19). The project was also outdated (lacked support for iPhone X even) and was not set up with a dependency manager, which made adding snapshot tests difficult. This replaces ParalayoutStudio with a new demo app that uses CocoaPods for dependency management (which inherently tests our CocoaPods integration) and includes a test suite set up to run snapshot tests. My plan is to use this demo app both as a way to show how Paralayout can be used and as a form of integration tests. It currently only has the skeleton for this new design, but it should be easy to add new sample screens. I've added a basic snapshot test for view spreading to kick off building out the snapshot test suite.
ParalayoutStudio, the old sample code for experimenting with Paralayout, was primarily focused on functionality around Label, which is being removed from the framework (#19). The project was also outdated (lacked support for iPhone X even) and was not set up with a dependency manager, which made adding snapshot tests difficult. This replaces ParalayoutStudio with a new demo app that uses CocoaPods for dependency management (which inherently tests our CocoaPods integration) and includes a test suite set up to run snapshot tests. My plan is to use this demo app both as a way to show how Paralayout can be used and as a form of integration tests. It currently only has the skeleton for this new design, but it should be easy to add new sample screens. I've added a basic snapshot test for view spreading to kick off building out the snapshot test suite.
Hi @NickEntin. Does Paralayout still offer a way to balance multiple lines of text in a UILabel? Was previously using the Label class + Perhaps that's surfaced somewhere else in the project, or is it just no longer available at all? Thanks! |
Hey @edwellbrook, after a lot of discussion we decided to remove the For now, I'd recommend copying Label.swift from the 0.9.1 release into your project. I think it should work standalone from any other changes in the Paralayout 1.0 release. |
Label
doesn't really belong in Paralayout anymore. It was originally very helpful in working around some quirks inUILabel
that made it difficult to align text properly to match the output of design tools. Many of those original issues have been resolved over the years, however, and so it is no longer providing much value in terms of layout. While it still provides additional functionality on top ofUILabel
, Paralayout is a layout framework and the functionality included should be scoped to only layout tools when possible.If the
Label
functionality is still useful to external consumers, we can consider moving it to its own micro-framework. If you use it and would be interested in this, please speak up. For now I propose that we remove it from the Paralayout entirely.The text was updated successfully, but these errors were encountered: