Python 3.12 test updates #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkpeprah
approved these changes
Jul 10, 2024
|
I'm not sure how to sign the CLA, should the automation be leaving a comment on the PR to do so? |
|
Let me double check, it should automatically run and post. |
|
I'm not sure why it failed to post. The Github settings page shows that it did. This should be the link: https://cla-assistant.io/square/pylink?pullRequest=204 |
|
I just end up in a loop, as you can see from the screenshot, I am signed in, yet the button still says sign in with GitHub to agree, clicking the button takes me back to the same page. Digging into the console logs, it looks like there is an auth issue, presumably between the cla-assistant app and square? |
hkpeprah
approved these changes
Jul 12, 2024
As far as I can tell, these tests have been incorrect but failure was masked until Python 3.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed test function calls that are removed in Python 3.
Fixed some test cases that likely were broken but failure was masked by calling an invalid function.
Closes #197