Update Zookeeper client and other minor maintenance #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copies the StartTestCluster function and related types and methods out of github.com/samuel/go-zookeeper/zk due to the functionality being removed from upstream in later versions.
The previous default of an empty string is an invalid path. "/" is the correct default root. This code is only used by tests in the config package.
Go 1.16 is the earliest version of Go that is still officially supported and receiving updates. This commit upgrades the declared language version to 1.16, adds testing for the latest point releases of go1.16 and go1.17, and drops testing for older versions.
michaelfinch
approved these changes
Feb 24, 2022
spenceral
approved these changes
Feb 24, 2022
The github.com/samuel/go-zookeeper module is no longer being maintained. All development on it has shifted to github.com/go-zookeeper/zk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to upgrade the Zookeeper client package. The old one, github.com/samuel/go-zookeeper, is no longer being maintained. All development on it has shifted to github.com/go-zookeeper/zk.
To make that change, the code needed a touch-up:
Additionally, this updates the module to use go1.16 conventions, since that is the earliest supported Go version. This isn't strictly needed; it's just keeping the build up-to-date for security patches.