Update rubocop version for CVE-2017-8418 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyczkowski
force-pushed
the
mmc/rubocop
branch
from
37f0bcb
to
c7f266f
Compare
|
|
mbyczkowski
force-pushed
the
mmc/rubocop
branch
from
c7f266f
to
76d3745
Compare
Rubocop got bumped from 0.38 to 0.77, so there were many changes that affected almost every file of rails-auth. Most of them came from adding magic comment `# frozen_string_literal: true`. I've added a few more options to .rubocop.yml, because either they applied more specifically to rails-auth project, or simply would create even more work for dubious outcome (like re-aligning multi-line hashes). Co-authored-by: Matthew McPherrin <mmc@squareup.com> Co-authored-by: Mat Byczkowski <mbyczkowski@squareup.com>
mbyczkowski
force-pushed
the
mmc/rubocop
branch
from
76d3745
to
468bac5
Compare
drcapulet
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rubocop version for CVE-2017-8418