Allows SquareReaderSDK.framework to be added to a root sub dir #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closed
|
@SudoPlz The travis job doesn't work with forked repo. Can you create a branch with your change from this repo directly? |
|
Closed in favour of #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
so that we no longer face
Module 'SquareReaderSDK' not foundwhen moving the framework file in a subdirectory.Related issues
Fix #49
Changelog
Made the
/../../../iosframework search path recursiveTest Plan
Move the
SquareReaderSDK.frameworkdirectory inside a folder calledframeworksin your {react-native root}/ios project dir. Before that change you'd see aModule 'SquareReaderSDK' not foundwhen trying to build the project.Not anymore.