Check the Object from the serviceMethodCache again #4126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a test
annotationParsingFailureObservedByMultipleWaitingThreads()
(modified from @JakeWharton 'sannotationParsingFailureObservedByWaitingThreads
) inRetrofitTest.java
to mock the situation I mentioned in #4114 . And I found that the code inbase:trunk
branch does failed the test and throw aClassCastException
(3 failures out of 10 test attempts)This pull request tries to deal with this extreme situation. To verify it, I have ran the test case for 20 times and all succeeded.