This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Move some calls onto QueueFile directly. #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Mar 2, 2017
| @@ -49,7 +49,7 @@ public boolean isEmpty() { | |||
| * If the queue's {@link #size()} is less than {@code max} then only {@link #size()} entries | |||
| * are read. | |||
| */ | |||
| public List<T> peek(int max) throws IOException { | |||
| public final List<T> peek(int max) throws IOException { | |||
There was a problem hiding this comment.
I think both of these should stay non-final since it's possible to provide more efficient implementations in subclasses.
There was a problem hiding this comment.
Oh, cool, I wasn't sure. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of a useless change. Feel free to close.