Plugin option + decoding support for UNRECOGNIZED constant #2886
+532
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
commented
Mar 28, 2024
Comment on lines
+258
to
+273
| assertThat(wireMessage.optional_easter_animal).isEqualTo(EasterAnimalK3.UNRECOGNIZED) | ||
| assertThat(wireMessage.identity_easter_animal).isEqualTo(EasterAnimalK3.UNRECOGNIZED) |
There was a problem hiding this comment.
Once those two lines pass, this PR is good.
Base automatically changed from
bquenaudon.2024-03-28.kotlingeneratorunrecognized
to
master
March 29, 2024 22:06
oldergod
force-pushed
the
bquenaudon.2024-03-28.testing
branch
from
8c471cd
to
9c3c0da
Compare
oldergod
changed the title
oldergod
force-pushed
the
bquenaudon.2024-03-28.testing
branch
from
9c3c0da
to
b869aeb
Compare
psymoon
approved these changes
Apr 4, 2024
oldergod
force-pushed
the
bquenaudon.2024-03-28.testing
branch
from
b869aeb
to
ba2ae20
Compare
oldergod
force-pushed
the
bquenaudon.2024-03-28.testing
branch
from
ba2ae20
to
26716de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.