Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update to help newbies #69

Closed
wants to merge 151 commits into from
Closed

Readme update to help newbies #69

wants to merge 151 commits into from

Conversation

daj
Copy link
Contributor

@daj daj commented Nov 20, 2013

Most people will be trying to do the compilation step before they get to the runtime step, so adding a download link there too.

[dl]: http://repository.sonatype.org/service/local/artifact/maven/redirect?r=central-proxy&g=com.squareup.wire&a=wire-runtime&v=LATEST
[dl_all]: http://search.maven.org/#search%7Cga%7C1%7Cg%3Acom.squareup.wire
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can deep-link directly to the latest version of this jar. Use the following URL:

http://repository.sonatype.org/service/local/artifact/maven/redirect?r=central-proxy&g=com.squareup.wire&a=wire-compiler&v=LATEST&c=jar-with-dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks - I didn't know how to deep link directly to it.

@daj
Copy link
Contributor Author

daj commented Nov 20, 2013

Hopefully that addresses the feedback - thanks!

Add an null check in finally clauses
@danrice67
Copy link
Collaborator

LGTM, please rebase.

@daj
Copy link
Contributor Author

daj commented Jan 13, 2014

I've rebased, you should hopefully be able to merge it now...

@danrice67
Copy link
Collaborator

Could you squash this into a single commit? (e.g., using git rebase -i)

JakeWharton and others added 25 commits January 13, 2014 11:00
If specified, emits a class that contains a constant list of all
extension classes generated during the compile.  This list is suitable
for passing to Wire's constructor at runtime to populate its internal
ExtensionRegistry.
Suppresses emission of all options and any extensions of MessageOptions
or FieldOptions.
@daj
Copy link
Contributor Author

daj commented Jan 13, 2014

Closing this messy pull request and sending a new one as #85

@daj daj closed this Jan 13, 2014
JakeWharton added a commit that referenced this pull request Apr 15, 2014
Produce aar in addition to apklib
JakeWharton added a commit that referenced this pull request Jul 13, 2015
Update to Java 7. Add quick parse method for Path types.
JakeWharton added a commit that referenced this pull request Jul 9, 2020
* commit 'cf32b70f0a075f15ae299aa7f904ec2d6beeae03':
  Point at the latest snapshot of SwiftPoet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants