kgctl: make peer name argument optional #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the peer name argument in the `kgctl connect` command optional. Now, the computer's hostname will be used as the default peer name when no argument is supplied. This is a good predictable feature that makes it easier to integrate with containers and environments like Kubernetes. Signed-off-by: squat <lserven@gmail.com>
squat
force-pushed
the
automatically_discover_hostname
branch
from
3ac5cc0
to
07f45d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the peer name argument in the
kgctl connectcommandoptional. Now, the computer's hostname will be used as the default peer
name when no argument is supplied. This is a good predictable feature
that makes it easier to integrate with containers and environments like
Kubernetes.
Signed-off-by: squat lserven@gmail.com