Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubeadm cilium manifest #386

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Fix kubeadm cilium manifest #386

merged 1 commit into from
Jun 22, 2024

Conversation

OrellBuehler
Copy link
Contributor

Fix property naming issues

squat
squat approved these changes Jun 22, 2024
View reviewed changes
Copy link
Owner

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow good catch!
I'd like to add e2e tests for verifying cillium in addition to the add-ons that are currently tested, i.e. flannel. That way we can avoid regressions here

@squat squat enabled auto-merge June 22, 2024 14:32
@squat squat merged commit e6bb174 into squat:main Jun 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrellBuehler @squat