Build updates #27
Closed
Build updates #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is basically intended to help getting #5 done, I'll open PRs for documentation (as in website component for TF providers) and Acceptance tests soonish. |
added 2 commits
February 21, 2018 09:03
Did not add all `vendor` files here.
|
@danielsreichenbach thanks so much for this contribution and sorry I let it get stale. Any chance you could rebase the PR on top of master so we could review and merge? |
|
No worries, I’ve been that guy myself 😅 I will rebase tonight and push an updated version. |
|
Thanks Daniel. There’s no hurry for this, since we still need acceptance tests anyways, I just don’t want to leave it hanging! |
This was referenced Feb 19, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a small issue with dependencies and updates the build system to be in line with what official Terraform providers use.
glide.yamlgo getbuildby default