This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Calculate UniqueID via increment #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to find unique id randomly, which is costly, do it sequentially instead. In this case, we have ~4 billion unique identifiers, and even if we exhaust them all, we will reset back to int.MinValue and start over. It also helps getting rid of locking in the finalizer.
|
I actually have no idea of the purpose of |
|
We're now testing this fix in our environment, will come back later with results. |
|
So far so good. The performance issues went away with this fix. |
|
@squid-box Hi! Could you take a look at this PR? We have been running this fix in our high-load environment for 7 months, so far no issues. |
|
@RoadTrain: Hi, sorry for being inactive for so long! I'll admit I also don't really understand the usage of UniqueID, just another part of the mystery that is SevenZipSharp 🤷. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to find unique id randomly, which is costly, do it sequentially instead.
In this case, we have ~4 billion unique identifiers, and even if we exhaust them all, we will reset back to
int.MinValueand start over.It also helps getting rid of locking in the finalizer.
Fixes #162