-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: implement Ip::Address::asText() #1739
base: master
Are you sure you want to change the base?
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c673207 - Browse repository at this point
Copy the full SHA c673207View commit details -
Configuration menu - View commit details
-
Copy full SHA for b97f3ed - Browse repository at this point
Copy the full SHA b97f3edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49b1423 - Browse repository at this point
Copy the full SHA 49b1423View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8979a90 - Browse repository at this point
Copy the full SHA 8979a90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e6b316 - Browse repository at this point
Copy the full SHA 7e6b316View commit details
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1ab9f10 - Browse repository at this point
Copy the full SHA 1ab9f10View commit details
Commits on Apr 9, 2024
-
Fix heap buffer overead in ConfigParser::UnQuote() (squid-cache#1763)
Detected by using AddressSanitizer.
Configuration menu - View commit details
-
Copy full SHA for 5f2ee67 - Browse repository at this point
Copy the full SHA 5f2ee67View commit details -
Do not blame cache_peer for CONNECT errors (squid-cache#1772)
ERROR: Connection to [such-and-such-cache_peer] failed TCP_TUNNEL/503 CONNECT nxdomain.test:443 FIRSTUP_PARENT Squid does not alert an admin about (and decrease health level of) a cache_peer that responded with an error to a GET request. Just like GET responses from a cache_peer, CONNECT responses may (and often do!) reflect client or origin server failures. We should not penalize cache_peers (and alert admins) until we can distinguish these frequent client/origin failures from (relatively rare) cache_peer problems. This change absolves cache_peers of CONNECT problems, restoring parity with GETs and restoring v4 behavior changed (probably by accident) in v5. Also removed Http::StatusCode parameter from failure notification functions because it became essentially unused after the primary Http::Tunneler changes. Tunneler was the only source of status code information that (in some cases) used received HTTP response to compute that status code. All other cases extracted that status code from Squid-generated errors. Those errors were arguably never meant to supply status code information for "this failure is not our fault" decision, and they do not supply 4xx status codes driving that decision. ### Problem evolution 2019 commit f5e1794 effectively started blaming cache_peer for all FwdState CONNECT errors. That functionality change was probably accidental, likely influenced by the names of noteConnectFailure() and peerConnectFailed() functions that abbreviated "Connection", making the functions look as applicable to CONNECT failures. Prior to that commit, the functions were never used for CONNECT errors. After it, FwdState started calling peerConnectFailed() for all CONNECT failures. In 2020 commit 25b0ce4, TunnelStateData started blaming cache_peers as well (by moving that FwdState-only error handling code into Tunneler). The same "accidental functionality change" speculations apply here. In 2022 commit 022dbab, we made an exception for 4xx CONNECT errors as folks deploying newer code started complaining about cache_peers getting blamed for client-caused errors (e.g., HTTP 403 Forbidden replies). We did not realize that the blaming code itself was an unwanted accident. Now we are getting complaints about cache_peers getting blamed for 502 and 503 CONNECT errors caused by, for example, domain names without IPs: As these CONNECT error responses are propagated from parent to child caches, every child cache in the chain logs ERRORs and every cache_peer in the chain gets its health counter decreased!
Configuration menu - View commit details
-
Copy full SHA for 0a15787 - Browse repository at this point
Copy the full SHA 0a15787View commit details -
Fix const-correctness of ACLHTTPHeaderData::match() parameter (squid-…
…cache#1771) ACLHTTPHeaderData::match() required a pointer to non-const HttpHeader but does not (and should not) modify the supplied HttpHeader. Also removed support for nil HttpHeader in that method. All callers already require HttpHeader presence. If that changes, it is the _caller_ that should decide what HttpHeader absence means (match, mismatch, exception/dunno, etc.); ACLHTTPHeaderData does not have enough information to make the right choice and, hence, should not be asked to choose. Also polished related #includes to remove unnecessary ones.
Configuration menu - View commit details
-
Copy full SHA for 95bd8d1 - Browse repository at this point
Copy the full SHA 95bd8d1View commit details -
Fix eCAP header includes (squid-cache#1753)
Squid style guidelines require .h files to be wrapped with HAVE_*_H protection and placed after all Squid internal file includes. Add the missing ./configure header checks to generate the needed wrappers and refactor the include sequences to meet current guidelines.
Configuration menu - View commit details
-
Copy full SHA for ba29475 - Browse repository at this point
Copy the full SHA ba29475View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b46e26 - Browse repository at this point
Copy the full SHA 1b46e26View commit details -
Have SQUID_CHECK_LIB_WORKS do state SAVE/RESTORE (squid-cache#1774)
Removing a lot of duplicated code and further simplifying library detection.
Configuration menu - View commit details
-
Copy full SHA for 6105648 - Browse repository at this point
Copy the full SHA 6105648View commit details -
NoNewGlobals for MemBlob::Stats (squid-cache#1749)
Detected by Coverity. CID 1554656: Initialization or destruction ordering is unspecified (GLOBAL_INIT_ORDER). Also update MemBlobStats initialization.
Configuration menu - View commit details
-
Copy full SHA for 468faa7 - Browse repository at this point
Copy the full SHA 468faa7View commit details -
Refactor and improve ErrorState::Dump (squid-cache#1730)
Rework the internals for generating output in ErrorState::Dump, used for expanding the '%W' token in error page templates. Also fix a bug with excessive html-quoting of the output.
Configuration menu - View commit details
-
Copy full SHA for bf14fcc - Browse repository at this point
Copy the full SHA bf14fccView commit details -
Configuration menu - View commit details
-
Copy full SHA for a422967 - Browse repository at this point
Copy the full SHA a422967View commit details -
NoNewGlobals for HttpHdrCc:ccLookupTable (squid-cache#1750)
Detected by Coverity. CID 1554655: Initialization or destruction ordering is unspecified (GLOBAL_INIT_ORDER). Also switched to compile-time checks for table initialization records.
Configuration menu - View commit details
-
Copy full SHA for 06644aa - Browse repository at this point
Copy the full SHA 06644aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 343f04b - Browse repository at this point
Copy the full SHA 343f04bView commit details -
Upgrade Acl::Node::name to SBuf; remove AclMatchedName global (squid-…
…cache#1766) AclMatchedName global has been localized into a regular Acl::Answer data member (Acl::Answer maintains the result of ACLChecklist evaluations). This long overdue change resolves an old TODO and XXXs, paving the way for Acl::Node reference counting. No significant functionality changes are expected, but it is possible that some deny_info configurations will now be handled better in reconfiguration corner cases (because Squid no longer forgets the name of the last checked ACL when a slow ACL check crosses reconfiguration barrier). Most of these changes are performance-neutral or -positive because they eliminate or reduce memory allocations and associated name copying (and more reduction will become possible after upgrading squid.conf parsers to use SBuf). This change adds SBuf object copies when Acl::Answer is propagated to ACLCB callbacks, but those read-only copies are cheap. Also renamed and polished aclGetDenyInfoPage() because we had to update its parameter type (to supply the last evaluated ACL). All callers were also supplying the same first argument (that is unlikely to change in the foreseeable future); that argument is now gone. We did not fix the redirect_allowed name and debugs(): Fixing that behavior deserves a dedicated change. Also polished legacy aclIsProxyAuth() profile and description because we have to change the parameter type (to supply the last evaluated ACL). Also removed 63-character aclname parameter limit for acl directives.
Configuration menu - View commit details
-
Copy full SHA for 6007f79 - Browse repository at this point
Copy the full SHA 6007f79View commit details -
Configuration menu - View commit details
-
Copy full SHA for beee7cb - Browse repository at this point
Copy the full SHA beee7cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96489ce - Browse repository at this point
Copy the full SHA 96489ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 899724a - Browse repository at this point
Copy the full SHA 899724aView commit details
Commits on Apr 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 794cad1 - Browse repository at this point
Copy the full SHA 794cad1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8f7293 - Browse repository at this point
Copy the full SHA c8f7293View commit details -
Configuration menu - View commit details
-
Copy full SHA for c73c17f - Browse repository at this point
Copy the full SHA c73c17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a38723a - Browse repository at this point
Copy the full SHA a38723aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4de23d0 - Browse repository at this point
Copy the full SHA 4de23d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for abf7d4d - Browse repository at this point
Copy the full SHA abf7d4dView commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9a19f31 - Browse repository at this point
Copy the full SHA 9a19f31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15ca319 - Browse repository at this point
Copy the full SHA 15ca319View commit details -
Configuration menu - View commit details
-
Copy full SHA for e29fa69 - Browse repository at this point
Copy the full SHA e29fa69View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec14be4 - Browse repository at this point
Copy the full SHA ec14be4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88402b1 - Browse repository at this point
Copy the full SHA 88402b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80dd4bf - Browse repository at this point
Copy the full SHA 80dd4bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8545ac0 - Browse repository at this point
Copy the full SHA 8545ac0View commit details