Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: update --with-tdb detection #1776

Closed
wants to merge 2 commits into from
Closed

Maintenance: update --with-tdb detection #1776

wants to merge 2 commits into from

Conversation

yadij
Copy link
Contributor

@yadij yadij commented Apr 5, 2024

No description provided.

@kinkie
Copy link
Contributor

kinkie commented Apr 5, 2024

Looks like a flaky test

@kinkie

This comment was marked as outdated.

Sign in to view
rousskov
rousskov previously requested changes Apr 5, 2024
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
@rousskov rousskov added the S-waiting-for-author author action is expected (and usually required) label Apr 5, 2024
@yadij yadij added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Apr 5, 2024
@yadij yadij requested a review from rousskov April 5, 2024 17:01
@rousskov rousskov removed their request for review April 5, 2024 17:28
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Apr 5, 2024
@yadij yadij requested a review from rousskov April 6, 2024 08:42
@yadij yadij added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Apr 6, 2024
@rousskov rousskov removed their request for review April 6, 2024 20:23
@rousskov rousskov dismissed their stale review April 6, 2024 20:23

My primary concern has been addressed.

@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Apr 6, 2024
@yadij yadij removed the S-waiting-for-author author action is expected (and usually required) label Apr 7, 2024
kinkie
kinkie approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@kinkie kinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let's ship it

@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Apr 8, 2024
@rousskov rousskov removed the S-could-use-an-approval An approval may speed this PR merger (but is not required) label Apr 8, 2024
squid-anubis pushed a commit that referenced this pull request Apr 9, 2024
@yadij @squid-anubis
Maintenance: update --with-tdb detection (#1776)
4f3f75b
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Apr 9, 2024
@squid-anubis squid-anubis removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Apr 9, 2024
@squid-anubis squid-anubis added the M-merged https://github.com/measurement-factory/anubis#pull-request-labels label Apr 9, 2024
kinkie pushed a commit to kinkie/squid that referenced this pull request Apr 9, 2024
@yadij @kinkie
Maintenance: update --with-tdb detection (squid-cache#1776)
beee7cb
@yadij yadij deleted the arc-autoconf-ng-42 branch April 10, 2024 11:31
kinkie pushed a commit to kinkie/squid that referenced this pull request Apr 12, 2024
@yadij @kinkie
Maintenance: update --with-tdb detection (squid-cache#1776)
19905ac
kinkie pushed a commit to kinkie/squid that referenced this pull request Apr 14, 2024
@yadij @kinkie
Maintenance: update --with-tdb detection (squid-cache#1776)
7017dc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov left review comments

@kinkie kinkie kinkie approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yadij @kinkie @rousskov @squid-anubis