Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module manifest is incorrect when using folder redirection for Documents #42

Open
casselc opened this issue Jan 6, 2017 · 3 comments
Open
Assignees
Labels

Comments

@casselc
Copy link

casselc commented Jan 6, 2017

The FormatsToProcess, NestedModules, and ModuleList elements of the module manifest are explicitly referencing the Documents folder in the user profile, and so the module fails to import when the Documents library has been redirected to another location.

Since the files referenced by those elements are directly in the module folder, I believe you should be able to remove the path altogether and just reference by file name (working for me locally).

@Jackbennett
Copy link

I just had to fix this and came here to pull request it but you don't check-in those files :/

If you still want the file paths, probably the safest change would be;

# Format files (.ps1xml) to be loaded when importing this module
FormatsToProcess = @("$PSScriptRoot\gShell.Format.ps1xml")

# Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
NestedModules = @("$PSScriptRoot\gShell.dll")

and also lower down;

# List of all modules packaged with this module.
ModuleList = @("$PSScriptRoot\gShell.dll")

@squid808
Copy link
Owner

Sorry for the delay, it's been that-time-of-year for me at work. I'll take a look at this as soon as I can, and see about checking in those installation files (perhaps still not the images, but the other non-binary files).

@squid808
Copy link
Owner

squid808 commented Feb 3, 2017

I've checked in those files, you can find them here. At this time, I'm not even sure we need the format file, it was an experiment from a long time ago and frankly it's probably not needed. I'll test around removing those lines or altering them and seeing what the behavior is and how I should proceed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants