feat: url schemes #363
Merged
feat: url schemes #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperstorm
commented
Apr 28, 2024
casperstorm
force-pushed
the
feat/ipc
branch
4 times, most recently
from
f2d95be
to
0275be6
Compare
|
@tarkah can you take this for a spin and see if you wanna add or change anything now? |
tarkah
approved these changes
May 14, 2024
There was a problem hiding this comment.
Awesome addition @casperstorm!
I've cleaned up a few things, made sure that URL is handled if halloy is booted from it the first time (not already running), and also handled the case of an existing server only joining requested channels vs overriding the server w/ a new one.
I've tested on linux and it works great. Let me know if you see anything else, otherwise I think we're good to merge.
Can't wait to add halloy:// urls for theme sharing in the future 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to open "irc" and "ircs" url links.