Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/persist window position and size #391

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

casperstorm
Copy link
Member

@casperstorm casperstorm commented Jun 6, 2024

fixes #379

@casperstorm casperstorm requested a review from tarkah June 6, 2024 20:48
Copy link
Member

@tarkah tarkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small things, otherwise this looks great!

data/src/window.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/window.rs Outdated Show resolved Hide resolved
@casperstorm casperstorm merged commit bf876c2 into main Jun 10, 2024
1 check passed
@casperstorm casperstorm deleted the feat/persist-window branch June 10, 2024 20:27
@darienm
Copy link

darienm commented Jul 9, 2024

Version 2024.8 MacOS does not return the window to the last used position or size. It's in a similar region on-screen (no longer centered) but not where it was left, which doesn't achieve the goal. Do you need more info? Primary screen is 3840x2160 and secondary screen is 2560x1600. (1) Window does not return to proper screen (2) Window seems to get smaller with each launch. (3) Window seems to disregard positions greater than around 1400x1400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Remember window size and position between launches
3 participants