Persistent storage #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squimrel
force-pushed
the
persistent-storage
branch
3 times, most recently
from
47f26d4
to
5a671da
Compare
squimrel
force-pushed
the
persistent-storage
branch
2 times, most recently
from
2c57c18
to
10fb6d6
Compare
squimrel
force-pushed
the
persistent-storage
branch
5 times, most recently
from
5caf975
to
11ab855
Compare
squimrel
force-pushed
the
persistent-storage
branch
7 times, most recently
from
2be5e33
to
1ed1642
Compare
squimrel
force-pushed
the
persistent-storage
branch
4 times, most recently
from
a4f6424
to
fe5d0a5
Compare
* Only use platform specific code for drive operations. * Break windows and mac builds. * Make linux code obey the new layout. * Add mount option.
Interrupt the control-flow using exceptions so that there's no need to check if there was an error after each function call. This is important because otherwise future code would get very messy. Always return 1 if an error occurred.
* Guard Drive::open. * Change Drive::addPartition signature to a format that doesn't look very portable. * Make it possible to modify configuration files on the image. * Try to add overlay partition and file. (Doesn't work yet.)
squimrel
force-pushed
the
persistent-storage
branch
from
3127225
to
12a0def
Compare
* Temporarly work around udisks. * Prepare to do this on Mac and Windows too.
Fix stuff.
* For all supported platforms. * Restructure. * Build mac dependencies.
to get a better overview of process interaction. Break progress bar.
* Deduplicate a lot of code. * Report percentage * 100 from helper. * Never pass temporary path to helper because it stopped dealing with those some time ago. * Fix udisks call.
so the user doesn't wonder why it shows him that it has finished writing when it hasn't. The bigger issue is that bytes written to the kernel cache report as being written but actually aren't yet flushed to the disk. There are ways to avoid this issue but it has a huge impact on the actual writing speed so it's really not worth fixing.
instead of an invokable method that acts as a setter.
As recommended by @MartinBriza.
except if it's the drive was created using Windows.
Zero out only the first 64kB of the overlay file because that's what dracut does when it resets the overlay.
because otherwise it'll be stuck at 10% forever for large files.
With the msdn writeFile one would have to maintain the seek position with the so called overlap parameter which is a pain since then a Drive::write call would have to lseek to find the current position and then update it again for third party programs that use ::write anayways.
squimrel
force-pushed
the
persistent-storage
branch
from
edf532b
to
77e37ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.