A few fixes and extensions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petterreinholdtsen
force-pushed
the
issue-3-fixes
branch
from
5e7c4dd
to
0580e2c
Compare
|
Note, this patch conflict slightly with pull request #11, as both fixes the install location for the shared library and a missing newline at the end of a cmake file. |
Here is some code extensions and bug fixes that you might be interested in. I have also included some rebased diffs from two forks of your code on github because they seemed interesting. One does a basic dump of returned data from the camera and the other allows access to multiple profiles. My code adds some extra fields that I was interested in as well as a couple of extra calls (including get/set NTP). I've also done some reworking of your time logic to better reflect UTC time vs. localtime and produced a utility to do time sync to cameras. The code is based on a patch from Brian D Scott, with some indentation cleanup. I did not complete the indentation cleanup, as it is unclear to me what the intended indentation for this project is. Fixes sr99622#3.
petterreinholdtsen
force-pushed
the
issue-3-fixes
branch
from
0580e2c
to
483ec93
Compare
|
onvif-time and onvif-util use getopt for command line parsing, which is not compatible for windows. These files have been removed |
petterreinholdtsen
added a commit
to petterreinholdtsen/libonvif
that referenced
this pull request
Oct 20, 2022
petterreinholdtsen
added a commit
to petterreinholdtsen/libonvif
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is some code extensions and bug fixes that you might be interested in. I have also included some rebased diffs from two forks of your code on github because they seemed interesting. One does a basic dump of returned data from the camera and the other allows access to multiple profiles.
My code adds some extra fields that I was interested in as well as a couple of extra calls (including get/set NTP).
I've also done some reworking of your time logic to better reflect UTC time vs. localtime and produced a utility to do time sync to cameras.
The code is based on a patch from Brian D Scott, with some indentation cleanup. I did not complete the indentation cleanup, as it is unclear to me what the intended indentation for this project is.
Fixes #3.