Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: highlight, .gitignore #200

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Conversation

vmarkovtsev
Copy link
Contributor

@vmarkovtsev vmarkovtsev commented Apr 12, 2018

  • gitignore missed some files
  • text is an invalid type for our highlighter which is based on highlight.js, the proper one is nohighlight
  • more highlight classes supported in the theme
  • remove redundant mathjax inclusion

@vmarkovtsev
Copy link
Contributor Author

difftree post wants Go highlight and for some reason it is broken, so we apply nohighlight workaround.

Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting the problem and for double checking it deploying into staging.
I created a new issue to address this «bug»
We can merge this to hotfix the wrong highlighting

@dpordomingo dpordomingo merged commit 10144bf into src-d:master Apr 13, 2018
@vmarkovtsev
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants