Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binaries are generated without .exe on Windows #85

Closed
smola opened this issue Aug 28, 2018 · 1 comment
Closed

Binaries are generated without .exe on Windows #85

smola opened this issue Aug 28, 2018 · 1 comment
Assignees
@smola
Labels
bug

Comments

@smola
Copy link
Contributor

smola commented Aug 28, 2018

Binary name ($(BIN)) should have .exe appended on Windows.
@smola smola added the bug label Aug 28, 2018
@smola smola self-assigned this Aug 29, 2018
smola added a commit that referenced this issue Aug 29, 2018
@smola
add .exe to Windows binaries, fixes #85
7b20464 
Signed-off-by: Santiago M. Mola <santi@mola.io>
smola added a commit that referenced this issue Aug 29, 2018
@smola
add .exe to Windows binaries, fixes #85
8ad0ba2 
Signed-off-by: Santiago M. Mola <santi@mola.io>
smola added a commit that referenced this issue Aug 29, 2018
@smola
add .exe to Windows binaries, fixes #85
39496b1 
Signed-off-by: Santiago M. Mola <santi@mola.io>
mcuadros added a commit that referenced this issue Aug 29, 2018
@mcuadros
Merge pull request #86 from src-d/exe-extension
e4c0ab4 
add .exe to Windows binaries, fixes #85
@smola
Copy link
Contributor Author

smola commented Aug 29, 2018

Fixed by #86

@smola smola closed this as completed Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smola smola

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smola