Auto update ':latest' tag from 'make docker-push' #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpordomingo
requested review from
abeaumont,
ajnavarro,
mcuadros,
rporres,
vmarkovtsev and
bzz
dpordomingo
changed the title
3 tasks
bzz
approved these changes
Dec 20, 2017
mcuadros
suggested changes
Dec 21, 2017
Makefile.main
Outdated
| docker push $(DOCKER_REGISTRY)/$(DOCKER_ORG)/$${repository}:$(TAG); \ | ||
| if [ $$? != 0 ]; then \ | ||
| echo "Something went wrong pushing the image."; \ | ||
| exit 1; \ | ||
| fi; \ | ||
| docker push $(DOCKER_REGISTRY)/$(DOCKER_ORG)/$${repository}:latest; \ |
There was a problem hiding this comment.
I suggest do this in another rule, and this rule only be used when you are in Travis.
There was a problem hiding this comment.
Great idea! Thanks!
I'll do so this evening!
dpordomingo
force-pushed
the
update-latest-image
branch
from
d7b3f62
to
5ae02e7
Compare
|
ok, this PR was superseded by #47 |
dpordomingo
force-pushed
the
update-latest-image
branch
from
c4ab91d
to
e0f7a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43 and Fixes bblfsh/web/issues/65
Required by https://github.com/src-d/backlog/issues/1074#issuecomment-351014012
If this PR is merged,
make docker-pushwill update the:latestdocker image tag automatically, pointing to the docker image just created by that target.If the "auto update
:latesttag" behavior is not desired for all projects already using::docker-pushtarget, an alternative would be to create (and push) the:latesttag from a new::docker-push-latesttarget, and call it from the CI when needed.