Skip downloading file by name if it's empty #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2018
|
TravisCI failure seems not to be related - it look un-happy with master as well, as it also fails on PR without any code changes i.e #40 |
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
|
Closing, as the working tree from |
campoy
reviewed
Apr 4, 2018
| splitFn := func(c rune) bool { | ||
| return c == '\n' | ||
| } | ||
| filenames = strings.FieldsFunc(string(b), splitFn) |
There was a problem hiding this comment.
I think it'd be easier to explicitly drop the empty lines inside of downloadFilenames and leave this code as is.
Basically start the for loop with:
for _, filename := range filenames {
filename = strings.TrimBlank(filename)
if filename == "" {
continue
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes panic from #41 and potentially #33