Add the external test linguist dir from env var #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 17 17
Lines 985 985
=======================================
Hits 827 827
Misses 96 96
Partials 62 62Continue to review full report at Codecov.
|
vmarkovtsev
force-pushed
the
patch-2
branch
2 times, most recently
from
1c1f4a0
to
4de11ba
Compare
This allows to use a cached directory with linguist instead of cloning and speeds up the tests by -10s on my local machine. Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
vmarkovtsev
force-pushed
the
patch-2
branch
from
4de11ba
to
250519b
Compare
abeaumont
suggested changes
Oct 26, 2017
common_test.go
Outdated
| s.repoLinguist, err = ioutil.TempDir("", "linguist-") | ||
| assert.NoError(s.T(), err) | ||
| s.repoLinguist = os.Getenv("ENRY_TEST_REPO") | ||
| s.cloned = len(s.repoLinguist) == 0 |
There was a problem hiding this comment.
It may be better to compare strings than lengths: s.repoLinguist == ""
| s.tmpLinguist, err = ioutil.TempDir("", "linguist-") | ||
| assert.NoError(s.T(), err) | ||
| s.tmpLinguist = os.Getenv("ENRY_TEST_REPO") | ||
| s.cloned = len(s.tmpLinguist) == 0 |
vmarkovtsev
force-pushed
the
patch-2
branch
2 times, most recently
from
fb2618d
to
89480f0
Compare
Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
|
@abeaumont Fixed |
abeaumont
reviewed
Oct 26, 2017
| cmd := exec.Command("git", "clone", lingustURL, s.tmpLinguist) | ||
| err = cmd.Run() | ||
| assert.NoError(s.T(), err) | ||
| if s.cloned { |
There was a problem hiding this comment.
This second if is not needed, it should be inside the previous one
Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
|
@abeaumont Fixed |
abeaumont
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use a cached directory with linguist instead of cloning and speeds up the tests by 3x on my local machine.