Java bindings: add some convenience #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 83.67% 83.67%
=======================================
Files 17 17
Lines 980 980
=======================================
Hits 820 820
Misses 98 98
Partials 62 62Continue to review full report at Codecov.
|
abeaumont
reviewed
Aug 11, 2017
| @@ -5,6 +5,8 @@ | |||
| import static tech.sourced.enry.GoUtils.*; | |||
|
|
|||
| public class Enry { | |||
| public static final Guess unknownLanguage = new Guess("UNK", false); | |||
There was a problem hiding this comment.
We use empty string for unknown language in Go, not sure if it'd be fit well here. If so, I'd go with the same convention (could be null in Java)
There was a problem hiding this comment.
Empty string sounds good
|
Changed to adhere Go conventions. History re-written in 0a6ed07 |
abeaumont
approved these changes
Aug 11, 2017
erizocosmico
approved these changes
Aug 11, 2017
|
thanks @bzz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor convenience for JVM clients:
Enry.unknownLanguageGuess.toString/.equals/.hashCode\cc @erizocosmico @abeaumont for review