Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/parser: integrate SHOW and DESCRIBE in the parser #74

Closed
smola opened this issue Dec 2, 2016 · 2 comments
Closed

sql/parser: integrate SHOW and DESCRIBE in the parser #74

smola opened this issue Dec 2, 2016 · 2 comments
Labels
enhancement New feature or request

Comments

@smola
Copy link
Contributor

smola commented Dec 2, 2016

Vitess SQL parser does not support SHOW and DESCRIBE. So we are currently matching them ad hoc before passing the query to the parser. They should be properly supported in the SQL parser, contributing it to Vitess or, if that's not possible, forking it.

@smola smola added the enhancement New feature or request label Dec 2, 2016
@campoy
Copy link
Contributor

campoy commented Jun 11, 2018

Why was this closed?

SHOW and DESCRIBE are still not supported, which causes issues when using gitbase from some libraries, such as pymysql.

@ajnavarro
Copy link
Contributor

This issue is closed because we move all that logic to https://github.com/src-d/go-mysql-server. You can see here a related issue: src-d/go-mysql-server#5

SHOW is a huge statement: https://dev.mysql.com/doc/refman/5.5/en/show.html . Right now we have only implemented SHOW TABLES;.

On the other hand, we only have implemented DESCRIBE TABLE tablename;, not SHOW COLUMNS FROM tablename. Why? legacy code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants