Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: sqlparser dependency version problem #90

Closed
hanzheng opened this issue Dec 31, 2016 · 1 comment
Closed

sql: sqlparser dependency version problem #90

hanzheng opened this issue Dec 31, 2016 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hanzheng
Copy link

hanzheng commented Dec 31, 2016

hi,

which youtube/vitess sqlparser version should I use to build gitql?

build from source:
gitql tag v0.3.0 with youtube/vitess branch release-2.1

sql/parse/parse.go:140: tn.Name.String undefined (type sqlparser.TableIdent has no field or method String)
sql/parse/parse.go:328: undefined: sqlparser.HexVal
sql/parse/parse.go:343: v.Name.Lowered undefined (type string has no field or method Lowered)

using go get:

ZhengdeMacBook-Pro:gitql hanzheng$ go get github.com/gitql/gitql
# github.com/gitql/gitql/sql/parse
sql/parse/parse.go:320: sqlparser.StrVal (type sqlparser.ValType) is not a type
sql/parse/parse.go:321: cannot convert v (type sqlparser.ValExpr) to type string
sql/parse/parse.go:324: undefined: sqlparser.NumVal
sql/parse/parse.go:326: cannot convert v (type sqlparser.ValExpr) to type string
sql/parse/parse.go:328: sqlparser.HexVal (type sqlparser.ValType) is not a type

thanks.

@smola smola added this to the v0.4.0 milestone Jan 5, 2017
@smola smola changed the title sqlparser dependency version problem sql: sqlparser dependency version problem Jan 5, 2017
@smola smola added the bug Something isn't working label Jan 5, 2017
@smola
Copy link
Contributor

smola commented Jan 5, 2017

@hanzheng Thanks for the report!

As a temporary solution, you can checkout an older version (e.g. c97b5be7d0116ae15241df7f6a6fe1dbc038b5df).

Soon we'll update the code and we might vendor the library to avoid future breakage.

@smola smola self-assigned this Jan 13, 2017
smola added a commit to smola/gitql that referenced this issue Jan 13, 2017
* update to latest sqlparser api.
* use gitql/vitess fork instead of youtube/vitess.
@smola smola closed this as completed in 0df31d4 Jan 13, 2017
dpordomingo pushed a commit to dpordomingo/gitbase that referenced this issue Mar 10, 2017
* update to latest sqlparser api.
* use gitql/vitess fork instead of youtube/vitess.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants