Small doc, CI and modules updates #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, badge image in README is broken. Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Following https://github.com/src-d/guide/blob/master/engineering/conventions/go.md#supported-go-versions Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small drive-by improvements:
doc: link for CI badge change to .com to fix image rendering in README
Before
After
CI updated to include 2 latest profiles, following src-d Go conventions for libraries
go module definition for
gopkg.in/src-d/go-errors.v1addedThis way, downstream Go 1.11+ clients can benefit from a module-awareness.
It's not mandatory and CI now includes several profiles, to make sure it works with and without modules. Comes with affordable CI build time increase: before:
1 min 7 sec, after1 min 52 sec