This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
utils/fs: add OpenFile method to filesystem interface. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smola
commented
Oct 31, 2016
smola
commented
- added OpenFile to fs.Filesystem interface.
- added OpenFile implementation to 'os' filesystem.
- bring back BaseFile.
* added OpenFile to fs.Filesystem interface. * added OpenFile implementation to 'os' filesystem. * bring back BaseFile.
mcuadros
suggested changes
Oct 31, 2016
| @@ -21,7 +21,8 @@ func NewOS(baseDir string) *OS { | |||
| } | |||
| } | |||
|
|
|||
| // Create creates a new GlusterFSFile | |||
| // Create creates a file and opens it with standard permissions | |||
| // and modes O_RDWR, O_CREATE and O_TRUNC. | |||
| func (fs *OS) Create(filename string) (File, error) { | |||
There was a problem hiding this comment.
to avoid duplicate code you can call fs.OpenFile(filename, os.O_RDWR|os.O_CREATE|os.O_TRUNC, 0666), and the same for Open
| @@ -38,3 +37,16 @@ type File interface { | |||
| } | |||
|
|
|||
| type FileInfo os.FileInfo | |||
|
|
|||
| type BaseFile struct { | |||
There was a problem hiding this comment.
I though that we are adding this to the bare package not to the OS one
There was a problem hiding this comment.
Removed wildcard import.
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* utils/fs: add OpenFile method to filesystem interface. * added OpenFile to fs.Filesystem interface. * added OpenFile implementation to 'os' filesystem. * bring back BaseFile. * utils/fs/os: do not use wildcard import. * utils/fs/os: implement Open and Create using OpenFile.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.