This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: packfile/scanner, readability/performance improvements, zlib pooling #1124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates scanner's
trackableReader
,byteReadSeeker
andteeReader
's functionality into onescannerReader
. I wanted the ability to have a pool of Scanners if need be, and offering aReset()
and dealing with all 3 readers was proving difficult. I believe this version is also easier to read.In addition:
zlib.NewReader
doesn't accept nil. This limitation is by-passed by priming the reader with a zero byte compressed payload. I couldn't find a better way of doing this.Flush()
. There's no need for this to be public.