This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when adding an "executable" file with
worktree.Add()
, something really strange happened: the git index file entry associated with that file had its SHA1 updated but not its size; which caused the file to appear both as "staged" and "unstaged" when runninggit status
:However, when running
git diff
, nothing shows up (ie. the fact that this file appears as unstaged is just an artifact of the file length not matching the one registered on the index)I guess (but I could be wrong) that the original intent of the line I changed was to avoid updating the size when dealing with a folder or a pipe or something like that... but for some reason,
IsRegular()
was used instead ofIsFile()
.If there is some hidden reason to use
IsRegular()
that I'm not aware of, please simply discard this pull request.