This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
remote: make Fetch atomic. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Current coverage is 77.03% (diff: 75.30%)@@ master #185 diff @@
==========================================
Files 93 93
Lines 5953 5987 +34
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4631 4612 -19
- Misses 836 890 +54
+ Partials 486 485 -1
|
|
@smola rebase |
mcuadros
suggested changes
Dec 15, 2016
| if err = remote.Connect(); err != nil { | ||
| return err | ||
| fetchRefSpecs := c.Fetch | ||
| if o.SingleBranch { |
There was a problem hiding this comment.
this code can go in a function to be more easy to read
|
|
||
| // Create resolved HEAD reference with remote prefix if it does not | ||
| // exist. This is needed when using single branch and HEAD. | ||
| for _, rs := range spec { |
There was a problem hiding this comment.
this code can go in a function
alcortesm
approved these changes
Dec 15, 2016
* Remote now exposes only Fetch. No Connect, Disconnect, etc. * Repository uses a private fetch method in Remote for Clone/Pull. * getting capabilities, HEAD or other information from remote requires using the lower level client. * add Fetch method to Repository.
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* Remote now exposes only Fetch. No Connect, Disconnect, etc. * Repository uses a private fetch method in Remote for Clone/Pull. * getting capabilities, HEAD or other information from remote requires using the lower level client. * add Fetch method to Repository.
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires using the lower level client.