Test issue#93. Error in []Struct properties #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpordomingo
changed the title
tests/kallax.go
Outdated
| @@ -1765,6 +1767,8 @@ func (r *JSONModel) Value(col string) (interface{}, error) { | |||
| return r.Foo, nil | |||
| case "bar": | |||
| return types.JSON(r.Bar), nil | |||
| case "baz_slice": | |||
| return types.Slice(r.BazSlice), nil | |||
There was a problem hiding this comment.
the problem might be this. It should be types.JSON, not types.Slice
There was a problem hiding this comment.
Yes, it is!!
now, lets see how to fix that autogenerated code :D
|
I think it's now solved @erizocosmico |
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 15 15
Lines 2241 2241
=======================================
Hits 1809 1809
Misses 293 293
Partials 139 139
Continue to review full report at Codecov.
|
erizocosmico
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
described by #93