Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Add sql/expression/literal_test.go #776

Closed
juanjux opened this issue Jun 28, 2019 · 4 comments
Closed

Add sql/expression/literal_test.go #776

juanjux opened this issue Jun 28, 2019 · 4 comments

Comments

@juanjux
Copy link
Contributor

juanjux commented Jun 28, 2019

Just noticed that the module is missing the test module.

@erizocosmico
Copy link
Contributor

Do you mean that file is missing?

@juanjux
Copy link
Contributor Author

juanjux commented Jun 28, 2019

Yes, should have an specific test module for the stuff there, I guess.

@erizocosmico
Copy link
Contributor

Not really, it just returns the literal kept in the struct. I don't think it's worth testing.

@juanjux
Copy link
Contributor Author

juanjux commented Jun 28, 2019

Fair enough, I'll add a test later if I see how I can evaluate the VarChar length and return an error in NewLiteral.

@juanjux juanjux closed this as completed Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants