-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix subpixel in cards #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but much better if we reuse vars
src/sass/components/cards.scss
Outdated
.cards__element__band { | ||
@include corporate-gradient(#36536C, #2377B6); | ||
position: absolute; | ||
height: 7px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is $size-card-top-border
src/sass/components/cards.scss
Outdated
@@ -216,11 +226,17 @@ | |||
header { | |||
display: flex; | |||
height: $size-project-card-height; | |||
padding-top: 7px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is $size-card-top-border
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
5c8054c
to
970bfc0
Compare
fixed @dpordomingo |
Lgtm |
Blog
Home
Projects