Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subpixel in cards #113

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Conversation

erizocosmico
Copy link
Contributor

Blog

screenshot_2017-08-01_17 04 50

Home

screenshot_2017-08-01_17 04 00
Projects

screenshot_2017-08-01_17 04 24

@erizocosmico erizocosmico mentioned this pull request Aug 1, 2017
11 tasks
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but much better if we reuse vars

.cards__element__band {
@include corporate-gradient(#36536C, #2377B6);
position: absolute;
height: 7px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is $size-card-top-border

@@ -216,11 +226,17 @@
header {
display: flex;
height: $size-project-card-height;
padding-top: 7px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is $size-card-top-border

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico
Copy link
Contributor Author

fixed @dpordomingo

@dpordomingo
Copy link
Contributor

Lgtm

@Serabe Serabe merged commit c432a6c into src-d:master Aug 2, 2017
@erizocosmico erizocosmico deleted the fix/subpixel-cards branch August 2, 2017 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants