lookout-sdk binary #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzz
changed the title
bzz
force-pushed
the
lookout-sdk-update
branch
2 times, most recently
from
4a7de2c
to
c4219b3
Compare
|
CI fails on python example due to |
carlosms
reviewed
Sep 4, 2018
_tools/install-lookout-latest.sh
Outdated
| echo "Unable to extract lookout release archive" >&2 | ||
| exit 2 | ||
| fi | ||
|
|
||
| if ! mv lookout_sdk_*/lookout .. ; then | ||
| echo "Unable to move lookout binary file" >&2 | ||
| if ! mv lookout-sdk_*/lookout-sdk ../lookout_sdk ; then |
There was a problem hiding this comment.
Why the rename from -sdk to _sdk?
There was a problem hiding this comment.
because it's lookout-sdk dir we are in, and then mv binary with the same name to ../lookout_sdk fails trying to overwrite it
There was a problem hiding this comment.
added a comment with clarifications
bzz
changed the title
Merged
|
Python packaging gong to handled in the separate PR |
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
bzz
force-pushed
the
lookout-sdk-update
branch
from
c4219b3
to
6af4668
Compare
smacker
reviewed
Sep 4, 2018
| @@ -12,7 +12,7 @@ curl -s --connect-timeout 5 \ | |||
| --retry-delay 0 \ | |||
| --retry-max-time 40\ | |||
| "https://api.github.com/repos/src-d/lookout/releases/latest" \ | |||
| | tee -a ../lookout-install.log \ | |||
| |& tee -a ../lookout-install.log \ | |||
There was a problem hiding this comment.
allthough it's bashism, this is a nice shortcut to re-direct both, stdin and stderr together
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
|
Conditionally disable python CI profile for now, until I fix the packaging in a separate PR. Going to merge as hotfix, as soon as CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix python lib packaging