Read config #55
Read config #55
Conversation
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
server.go
Outdated
| } | ||
|
|
||
| // Config is a server configuration | ||
| type Config struct { |
There was a problem hiding this comment.
a name like ServerConfig may be could help avoid the confusion?
| ) | ||
|
|
||
| // ToStruct converts a map[string]interface{} to a types.Struct | ||
| func ToStruct(v map[string]interface{}) *types.Struct { |
There was a problem hiding this comment.
I did not use gogo protobuf very much, so could you please share a bit, why in order to create new Struct a https://godoc.org/github.com/gogo/protobuf/types#NewPopulatedStruct would not work for us?
There was a problem hiding this comment.
Because it accepts randyStruct but we need map[string]interface{}.
We parse unknown structure from yaml, the only type we can use is map[string]interface{}.
|
Overall SGTM, but a bit confused with how instances of type.Struct are created. |
|
@bzz please suggest any other way to create Struct if you know any. |
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
|
I do not, but my hope here was that may be you, as an author, have already done some kind of research and could share the results i.e if some gogo/protobuf extensions might be able to provide such thing. If not - it is fine just to say that you did not. I.e one helpful feedback would include pointing to the fact that official Golang protobuf impl is not going to provide this golang/protobuf#370 and clients are expected to implement the conversion \w reflections and type assertions, as you did here. |
|
Of course, I have done research. I found nothing better than creating a custom transformer. So I had to implement it by myself. You see it in PR. Your point is it looks "confused". Sadly, I don't know how to make it less confusing. |
Part of #20
There is no merging (yet?). Local configuration of analyzer just replaces the global one.