Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #47
Fix: #11
Changes:
-v
flag overrides log level to debug (as discussed before)Reasoning:
Internal gRPC logging logs quite much useless staff without a possibility to filter it by level or anyhow else. The only useful logs I have noticed are connection change status.
Internal gRPC logging doesn't log calls which are very useful. Existing logrus middleware requires workaround because we use
src-d/go-log
instead of pure logrus. Another problem it logs only when a request is finished. In my experience, it's very useful to log when request has come too in production. (helps to debug cases when the server received request but never responded because of panic/restart/whatever)It's also very useful for our SDK, when the changes are big enough you can see that request is actually processing instead of empty logs for a dozen seconds. To solve these problems I have created very simple interceptors based on
src-d/go-log
.