-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: define NormalFloat and FloatBorder #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its a draft for now, I need to make sure there's no new issues introduced |
This brings popup windows more in line with each other. The change was prompted by `ChatGPT.nvim` plugin that use telescope as a dependency, but the borders looked off. `NormalFloat` was linked to `Pmenu`, `Pmenu` is used for completion, and needs to be a different background color than NormalFloat, so I set NormalFloat to srcery_black `FloatBorder` was linked via `FloatBorder` -> `WinSeparator` -> `VertSplit` which is set to `bright_white`, but Telescope uses white as the border color, so I define that for `FloatBorder` as well ```viml call s:HL('VertSplit', s:bright_white, g:srcery_bg) ```
no issues detected |
I copied the following script from this: function! BreakHabitsWindow() abort
" Define the size of the floating window
let width = 50
let height = 10
" Create the scratch buffer displayed in the floating window
let buf = nvim_create_buf(v:false, v:true)
" Get the current UI
let ui = nvim_list_uis()[0]
" Create the floating window
let opts = {'relative': 'editor',
\ 'width': width,
\ 'height': height,
\ 'col': (ui.width/2) - (width/2),
\ 'row': (ui.height/2) - (height/2),
\ 'anchor': 'NW',
\ 'style': 'minimal',
\ }
let win = nvim_open_win(buf, 1, opts)
" create the lines to draw a box
let horizontal_border = '+' . repeat('-', width - 2) . '+'
let empty_line = '|' . repeat(' ', width - 2) . '|'
let lines = flatten([horizontal_border, map(range(height-2), 'empty_line'), horizontal_border])
" set the box in the buffer
call nvim_buf_set_lines(buf, 0, -1, v:false, lines)
endfunction To be clear, the popup should be black and the border white? There is a bug in the code that makes the example a bit broken. I'm not versed in Vimscript, so for now this should suffice. |
MindTooth
approved these changes
Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings popup windows more in line with each other. The change was prompted by
ChatGPT.nvim
plugin that use telescope as a dependency, but the borders looked off.NormalFloat
was linked toPmenu
,Pmenu
is used for completion, and needs to be a different background color than NormalFloat, so I set NormalFloat to srcery_blackFloatBorder
was linked viaFloatBorder
->WinSeparator
->VertSplit
which is set tobright_white
, but Telescope uses white as the border color, so I define that forFloatBorder
as well