fix: no contrast issue for lsp popups #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue was introduced with 2e9b1d4, defining NormalFloat to srcery_bg was a bad idea and broke other popups, due to lacking background contrast. I left in the border fix though, so that popup borders match what's configured for telescope. This still leaves some plugin borders looking a bit off, especially if they configure the background to something other than NormalFloat. Fixes: #115
MindTooth
approved these changes
Feb 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was introduced with 2e9b1d4, defining NormalFloat to srcery_bg was a bad idea and broke other popups, due to lacking background contrast.
I left in the border fix though, so that popup borders match what's configured for telescope.
This still leaves some plugin borders looking a bit off, especially if they configure the background to something other than NormalFloat.
Fixes: #115